-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoModel Notebooks #12013
AutoModel Notebooks #12013
Conversation
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed the review of tutorials/llm/hf/sft.ipynb and provided some copyedits and suggested revisions.
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed tutorials/llm/hf/peft.ipynb and tutorials/llm/hf/sft.ipynb and provided a few copyedits. Double-checked both files again to ensure that the same edits were made to both files. I missed a few the first time.
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
…NeMo into onur/automodel_notebooks
@jgerh Addressed the reviews. Could you please approve if it looks good to you? |
[🤖]: Hi @oyilmaz-nvidia 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
* AutoModel Notebooks Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * update sft notebook Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Added the output generation Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Cleaning the notebook Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Added the single gpu note Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Updating the notebooks after review Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Addressed the PR reviews Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> --------- Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
What does this PR do ?
Adds AutoModel notebooks.