Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoModel Notebooks #12013

Merged
merged 10 commits into from
Feb 13, 2025
Merged

AutoModel Notebooks #12013

merged 10 commits into from
Feb 13, 2025

Conversation

oyilmaz-nvidia
Copy link
Collaborator

What does this PR do ?

Adds AutoModel notebooks.

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@akoumpa akoumpa requested a review from jgerh February 3, 2025 17:24
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Copy link
Collaborator

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the review of tutorials/llm/hf/sft.ipynb and provided some copyedits and suggested revisions.

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
@oyilmaz-nvidia oyilmaz-nvidia marked this pull request as ready for review February 5, 2025 20:35
Copy link
Collaborator

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed tutorials/llm/hf/peft.ipynb and tutorials/llm/hf/sft.ipynb and provided a few copyedits. Double-checked both files again to ensure that the same edits were made to both files. I missed a few the first time.

@oyilmaz-nvidia
Copy link
Collaborator Author

@jgerh Addressed the reviews. Could you please approve if it looks good to you?

@oyilmaz-nvidia oyilmaz-nvidia enabled auto-merge (squash) February 12, 2025 06:35
Copy link
Contributor

[🤖]: Hi @oyilmaz-nvidia 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@oyilmaz-nvidia oyilmaz-nvidia merged commit 2ba7af9 into main Feb 13, 2025
218 checks passed
@oyilmaz-nvidia oyilmaz-nvidia deleted the onur/automodel_notebooks branch February 13, 2025 06:04
@BoxiangW BoxiangW self-requested a review February 13, 2025 06:31
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
* AutoModel Notebooks

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* update sft notebook

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Added the output generation

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Cleaning the notebook

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Added the single gpu note

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Updating the notebooks after review

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

* Addressed the PR reviews

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>

---------

Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants