-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid init_ddp for inference #12011
Avoid init_ddp for inference #12011
Conversation
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified:
Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified working. thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12011 +/- ##
==========================================
- Coverage 30.30% 30.30% -0.01%
==========================================
Files 1387 1387
Lines 176283 176285 +2
Branches 27091 27092 +1
==========================================
Hits 53422 53422
- Misses 118775 118777 +2
Partials 4086 4086 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: athitten <athitten@users.noreply.github.com>
b9b5c61
to
d637242
Compare
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
[🤖]: Hi @athitten 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
* Avoid init_ddp for inference Signed-off-by: Abhishree <abhishreetm@gmail.com> * Apply isort and black reformatting Signed-off-by: athitten <athitten@users.noreply.github.com> * Remove unused import Signed-off-by: Abhishree <abhishreetm@gmail.com> * More Pylint fixes Signed-off-by: Abhishree <abhishreetm@gmail.com> * Fix string formatting Signed-off-by: Abhishree <abhishreetm@gmail.com> * Another line too long fix Signed-off-by: Abhishree <abhishreetm@gmail.com> * fix lora inference Signed-off-by: Chen Cui <chcui@nvidia.com> --------- Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: athitten <athitten@users.noreply.github.com> Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: athitten <athitten@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
* Avoid init_ddp for inference * Apply isort and black reformatting * Remove unused import * More Pylint fixes * Fix string formatting * Another line too long fix * fix lora inference --------- Signed-off-by: Abhishree <abhishreetm@gmail.com> Signed-off-by: athitten <athitten@users.noreply.github.com> Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com> Co-authored-by: athitten <athitten@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com>
What does this PR do ?
Uses PTL's Enum TrainerFn to check if the stage is TESTING or not and skips init_ddp in nemo/lightning/megatron_parallel.py if TESTING as it can cause OOM during inference.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information