Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set zarr range to >=2.18.2 and <3.0.0 #12005

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Set zarr range to >=2.18.2 and <3.0.0 #12005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/requirements_deploy.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ nvidia-pytriton
pydantic-settings
tensorstore
uvicorn
zarr
zarr>=2.18.2,<3.0.0
2 changes: 1 addition & 1 deletion requirements/requirements_infer.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ nvidia-pytriton
pydantic-settings
tensorstore
uvicorn
zarr
zarr>=2.18.2,<3.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chtruong814 👋 This file is in fact a copy of requirements_deploy.txt as there was a rename pursued recently here #11749 (comment) (because these are reqs for nemo.deploy submodule in fact).

Could you please help us to propagate the change to use requirements_deploy.txt instead of requirements_infer.txt in vLLM virtualenv setup here

NeMo/reinstall.sh

Line 61 in 18e2bd8

-r /workspace/requirements/requirements_infer.txt

Otherwise I'll do that in a separate MR

CC @ko3n1g

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries. I don't mind making that additional change. We will also need to update the docker build in nemo-ci separately before deleting requirements_infer.txt it seems.

@thomasdhc @pablo-garay @ko3n1g we ok waiting until end of day or tomorrow even to let tests run again after I make this change? Or we just merge this now and I can open a separate MR to follow through on these other recommended changes? I'm happy to handle however y'all recommend.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ok I made a reflection since pipeline passed maybe it's better to merge it as-is

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and change && remove the other file on the next occasion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. I'll merge and open a small MR next to update to use requirements_deploy.txt and delete requirements_infer.txt.

2 changes: 1 addition & 1 deletion requirements/requirements_nlp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ sacrebleu # manually install sacrebleu[ja] for Japanese support; MeCab is unsup
sentence_transformers
tensorstore
tiktoken==0.7.0
zarr
zarr>=2.18.2,<3.0.0
Loading