Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run unit tests on main #11986

Merged
merged 33 commits into from
Feb 3, 2025
Merged

ci: Run unit tests on main #11986

merged 33 commits into from
Feb 3, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 29, 2025

What does this PR do ?

For unit test coverage, we need a baseline against which we can compare a PR. This baseline should come from branch main. So this PR allows running unit tests only on push to main. Therefore, with each merge of a PR we will now run the unit test suite on main. However, we have concurrency control activated so if multiple PRs get merged within a short span old runs will be cancelled prematurely so that only for the most recent merge/push to main a workflow is running.

After unit tests finish on main, we compute, aggreate and upload coverage results of main.

This can later be used by PRs. PRs will compute their own coverage result, download the baseline of main and compare against.

NOTE: Comparing against main can only be activated in cicd-main.yml after we have merged this PR.

Pipelines:

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ko3n1g added 22 commits January 28, 2025 16:56
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@github-actions github-actions bot added the CI label Jan 29, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 29, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g removed the Run CICD label Jan 29, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 2, 2025
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/run-unit-tests-on-main branch from d62b982 to fcb2e7e Compare February 2, 2025 23:29
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 2, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/run-unit-tests-on-main branch from fcb2e7e to 6add5b3 Compare February 2, 2025 23:34
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 2, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
Copy link
Contributor

github-actions bot commented Feb 3, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 3, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 3, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 3, 2025
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 3, 2025
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ko3n1g ko3n1g merged commit 46c2c11 into main Feb 3, 2025
192 of 209 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/run-unit-tests-on-main branch February 3, 2025 12:53
BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
* test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* re-add all tests

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* finalize

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* cleanup

Signed-off-by: oliver könig <okoenig@nvidia.com>

* document

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* add codecov

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* f

Signed-off-by: oliver könig <okoenig@nvidia.com>

* re-add all tests

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* finalize

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* cleanup

Signed-off-by: oliver könig <okoenig@nvidia.com>

* document

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* add codecov

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants