Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Retry on timeout #11974

Merged
merged 2 commits into from
Feb 4, 2025
Merged

ci: Retry on timeout #11974

merged 2 commits into from
Feb 4, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 28, 2025

What does this PR do ?

This PR improves resiliency by auto-retrying tests that ran into timeouts. We retry two times (3 runs in total) and only retry on timeout violation. In the run overview, retries can be seen via Annotation.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Jan 28, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 29, 2025
@github-actions github-actions bot added the core Changes to NeMo Core label Jan 29, 2025
@ko3n1g ko3n1g added Run CICD and removed core Changes to NeMo Core labels Jan 29, 2025
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 30, 2025
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@github-actions github-actions bot added the core Changes to NeMo Core label Jan 31, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 31, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 1, 2025
@ko3n1g ko3n1g marked this pull request as ready for review February 2, 2025 00:02
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 2, 2025
Copy link
Contributor

github-actions bot commented Feb 2, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g enabled auto-merge (squash) February 2, 2025 08:46
chtruong814
chtruong814 previously approved these changes Feb 3, 2025
Copy link
Collaborator

@chtruong814 chtruong814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. I'm glad we're limiting it to retrying on timeouts only rather than everything.

Just had one clarification question but overall looks good to me.

@ko3n1g ko3n1g force-pushed the ko3n1g/ci/retry-action branch from 881fe59 to f9a2987 Compare February 3, 2025 16:16
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 3, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.35%. Comparing base (48f10af) to head (4ef2c61).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11974      +/-   ##
==========================================
+ Coverage   30.30%   30.35%   +0.04%     
==========================================
  Files        1387     1387              
  Lines      176283   176283              
  Branches    27091    27091              
==========================================
+ Hits        53422    53505      +83     
+ Misses     118775   118670     -105     
- Partials     4086     4108      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g disabled auto-merge February 4, 2025 07:14
@ko3n1g ko3n1g merged commit ad169fd into main Feb 4, 2025
220 of 221 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/retry-action branch February 4, 2025 07:14
BoxiangW pushed a commit that referenced this pull request Feb 7, 2025
* ci: Run unit tests on `main`

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* ci: Run unit tests on `main`

Signed-off-by: oliver könig <okoenig@nvidia.com>

* fix

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI core Changes to NeMo Core Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants