Support positional args in LazyEntrypoint._add_overwrite
#136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I found that
nemo_run.cli.entrypoint
doesn't support positional args when using CLI, but the docstrings from NeMo imply that it should:https://github.com/NVIDIA/NeMo/blob/d82f53a23d013cfe6928a514f530b74fc3ab2636/nemo/collections/llm/api.py#L511-L521
This PR adds support for positional args by trying to retrieve the argument names first in
LazyEntrypoint._add_overwrite
.A corresponding test has been added to verify these changes.