Skip to content

Commit

Permalink
Upgrade skypilot to 0.7.0
Browse files Browse the repository at this point in the history
Signed-off-by: Hemil Desai <hemild@nvidia.com>
  • Loading branch information
hemildesai committed Nov 7, 2024
1 parent 5287e1f commit 3c79985
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ docker_persistent = "nemo_run.run.torchx_backend.schedulers.docker:create_schedu

[project.optional-dependencies]
skypilot = [
"skypilot[kubernetes]>=v0.6.1",
"skypilot[kubernetes]>=v0.7.0",
]
skypilot-all = [
"skypilot[all]>=v0.6.1",
"skypilot[all]>=v0.7.0",
]

[build-system]
Expand Down
6 changes: 5 additions & 1 deletion src/nemo_run/core/execution/skypilot.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import subprocess
from dataclasses import dataclass, field
from pathlib import Path
from typing import Optional, Type, Union
from typing import Any, Optional, Type, Union

from invoke.context import Context

Expand Down Expand Up @@ -104,6 +104,7 @@ class SkypilotExecutor(Executor):
autodown: bool = False
idle_minutes_to_autostop: Optional[int] = None
torchrun_nproc_per_node: Optional[int] = None
cluster_config_overrides: Optional[dict[str, Any]] = None
packager: Packager = field(default_factory=lambda: GitArchivePackager()) # type: ignore # noqa: F821

def __post_init__(self):
Expand Down Expand Up @@ -182,6 +183,9 @@ def parse_attr(attr: str):
parse_attr(attr)

resources_cfg["any_of"] = any_of
if self.cluster_config_overrides:
resources_cfg["_cluster_config_overrides"] = self.cluster_config_overrides

resources = Resources.from_yaml_config(resources_cfg)

return resources # type: ignore
Expand Down

0 comments on commit 3c79985

Please sign in to comment.