Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test cases for t5x finetuning+eval with and without TE #359

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

terrykong
Copy link
Contributor

No description provided.

@terrykong
Copy link
Contributor Author

Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold it off until the current CI is fully fixed?

Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we revisit this PR once #401 is merged?

@@ -7,7 +7,7 @@ print_var() {
}

usage() {
echo "Test T5X throughput on a fake-data Wikipedia benchmark."
echo "Test T5X throughput on a fake-data Wikipedia benchmark or real squad."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 'real squad'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By real squad, I mean "Stanford Question Answering Dataset (SQuAD)". I can use this casing to avoid confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants