nsys-jax: optimise data loading and .zip creation #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/nsys-jax-python-opt
branch
6 times, most recently
from
74a3d94 to
d8056e0
Compare
…ax Python code clearer
…n profiles clearer
Plumb through `prefix` so it's more convenient to explicitly set the input data path.
…v with Python's lzma.
olupton
force-pushed
the
olupton/nsys-jax-python-opt
branch
from
61357e9 to
4bf5946
Compare
gspschmid
approved these changes
Jan 10, 2025
|
Here's what a single sweep over all the comm/compute intervals might look like: https://gist.github.com/gspschmid/478b056b42a5c81e00999617b18d5b71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rough measurements on vanilla
jax-nccl-testand 8xH100:The differences are more pronounced on larger workloads with more activity.
The two bigger changes are:
.csvto.parquetas part ofnsys-jaxto avoid compressing.csvwith Python'slzmamodule, which is slow and single-threaded. This speeds upnsys-jaxand subsequent data-loading.Otherwise there are some tweaks to pandas usage and minor reorganisations to make Python profiles more informative, and minor bugfixes in the example Jupyter notebook.