Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing perf/loss baselines for paxml #272

Closed
terrykong opened this issue Sep 29, 2023 · 2 comments
Closed

Add missing perf/loss baselines for paxml #272

terrykong opened this issue Sep 29, 2023 · 2 comments
Assignees

Comments

@terrykong
Copy link
Contributor

There are currently still two missing tests for the paxml MGMN test suite:

Tasks

Preview Give feedback
No tasks being tracked yet.

@ashors1 has an example run showing that 2DP2TP4PP is now working, so we should re-run to get that baseline now (without TE first)

Then we should add TP=8 back when it's fixed

@terrykong
Copy link
Contributor Author

Also, we should probably pytest.mark.skip some of the parametrizations for which we do not have baselines for so that when inspecting the CI output, we can know that the coverage is not complete:

@pytest.mark.parametrize("baseline_filename", os.listdir(baselines_dir))

@nouiz
Copy link
Collaborator

nouiz commented Jan 20, 2025

We don't test pax anymore.

@nouiz nouiz closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants