-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional lowering to Host IR in FusionKernelRuntime #3835
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we have all the logic there -- it'll just be a matter of code motion and refactor.
Co-authored-by: Jingyue Wu <wujingyue@gmail.com>
… into nsarka/hostir-integration-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration looks good and clean, thank you! I just left a couple of questions/remarks
This reverts commit 6d830d1. Will do this in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
It needs a better title that describes the actual functionality. |
Co-authored-by: Jingyue Wu <wujingyue@gmail.com>
This PR adds milestone 2 from Jingyue's document Initial Integration of Host IR to FusionExecutorCache
It adds an optional codepath in FusionKernelRuntime (FKR) to lower a fusion to Host IR. When enabled, FKR will create a HostIrEvaluator, which has a container that all of the fusion's expressions are pushed to. Expressions lowered to a kernel are launched with the LaunchKernel HostIr.