feat: do not retry for client exceptions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruromero
force-pushed
the
4xx-retry-upstream
branch
from
7083fe6 to
55dd0b1
Compare
ashsong-nv
requested changes
Dec 21, 2024
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
ruromero
force-pushed
the
4xx-retry-upstream
branch
from
337fa9a to
dfa0dd5
Compare
ashsong-nv
approved these changes
Feb 14, 2025
|
No problem at all. Happy to collaborate 🚀 |
ruromero
pushed a commit
to ruromero/vulnerability-analysis
that referenced
this pull request
Mar 6, 2025
fix: add explicit docker format for container building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most client exceptions should not be retried. When a resource is not found, not authorized or bad request errors are clear examples that a retry will not change the result and only delay the response.
This change only affects the async request_with_retry as the sync version belongs to the Morpheus SDK. This change will only affect the intel retrieval.