H5 worker thread cannot be terminated at will

[leofang]

This is a follow-up of #26. The following code snippet was commented out because it would freeze the whole window:
https://github.com/NSLS-II/ptycho_gui/blob/211041eed91a5e4d0bb64a12d8f6a0bc5599daa0/nsls2ptycho/ptycho_gui.py#L973-L975
The offending call is thread.terminate(). As a result, currently during batch processing if one clicks "Stop", the H5 worker will still finish up the work in the background. Only the whole processing queue is killed.

If a more recent Qt/PyQt5 is available (at least 5.10) we should revisit this problem. I suspect it's the underlying implementation causing the problem.

[leofang]

Need to ask Anaconda folks to update Qt/PyQt: ContinuumIO/anaconda-issues#9124

[leofang]

If a more recent Qt/PyQt5 is available (at least 5.10) we should revisit this problem. I suspect it's the underlying implementation causing the problem.

It's probably not this reason. Tried building PyQt 5.12.3 (conda-forge/pyqt-feedstock#61) on top of condo-forge's new Qt 5.12.1 (conda-forge/qt-feedstock#110). Still hangs. I probably used thread.terminate() wrong, but I still can't figure out why...

[tacaswell]

What is the type of HardWorker?

[leofang]

It inherits from QThread and its run method is overridden:
https://github.com/NSLS-II/ptycho_gui/blob/211041eed91a5e4d0bb64a12d8f6a0bc5599daa0/nsls2ptycho/core/ptycho_recon.py#L197-L222