Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is there a get_max_countc? #62

Open
ambarb opened this issue Feb 12, 2021 · 0 comments
Open

Why is there a get_max_countc? #62

ambarb opened this issue Feb 12, 2021 · 0 comments
Assignees
@afluerasu @yugangzhang @xmchenGH
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) question V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Feb 12, 2021

It seems like there is a function in skbeam.roi that handles compressed data in the lowest level function for visibility (xsvsc_single())?

pyCHX/pyCHX/chx_specklecp.py

Lines 254 to 255 in 6e991bb

if max_cts is None:
max_cts = roi.roi_max_counts(FD, label_array)

Is this skbeam function wrong? Or was this an effort to have more control for technical reason specific to the CHX detector?
@ambarb ambarb added _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) question V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afluerasu afluerasu

@yugangzhang yugangzhang

@xmchenGH xmchenGH

Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) question V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afluerasu @yugangzhang @ambarb @xmchenGH