Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test and delete tqdm patch #50

Open
3 tasks
ambarb opened this issue Feb 2, 2021 · 1 comment
Open
3 tasks

test and delete tqdm patch #50

ambarb opened this issue Feb 2, 2021 · 1 comment
Assignees
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX

Comments

@ambarb
Copy link
Collaborator

ambarb commented Feb 2, 2021

# for a convenient status bar
try:
from tqdm import tqdm
except ImportError:
def tqdm(iterator):
return iterator

  • remove patch
  • global fix to imports (see below)
  • use in _commonspeckle.chx_speckle or merge with _commonspeckle.chx_specklecp
@ambarb ambarb self-assigned this Feb 2, 2021
@ambarb ambarb added _commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX labels Feb 2, 2021
@ambarb
Copy link
Collaborator Author

ambarb commented Feb 2, 2021

are other import methods are used without patch in all modules. both use tqdm and there are a mixture of implementations.

  1. from tqdm import tqdm in chx_libs and then import chx_libs
  2. from tqdm import tqdm

for the final implementation, we should choose least dependancies unless we end up with a very long list of standard imports that are the same for several modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_commonspeckle part of V2, but strictly related to a common repo (speckle + maybe scattering) V2 required to move towards share XPCS/speckle analysis for CHX/CSX
Projects
None yet
Development

No branches or pull requests

1 participant