-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for Pareto optimization #65
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I posted a few comments and suggestions below.
I think what is missing is an example (Jupyter/Sphinx) to demonstrate the Pareto front optimization. Can it be added, please?
src/blop/plotting.py
Outdated
DEFAULT_COLORMAP = "magma" | ||
DEFAULT_COLORMAP = "turbo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's better about this color map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values near 1 are hard to see on a white background. Turbo goes from red to blue and isn't white in the middle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment/note about it next to the color map assignment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an example. The "approving" review was preliminary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, suggested a couple of minor corrections below, it's good to go after that.
Just to confirm - the learning process will still be the same, i.e. no special input is needed to declare we want to use the Pareto-efficient optimization. The plotting will help to understand the Pareto front and then one can pick some points from the front. Is my understanding correct?
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
Yup, nothing is changed. |
Add functionality for Pareto optimization
Pareto optimization is an alternative to scalarization where we explore the Pareto front (https://en.wikipedia.org/wiki/Pareto_efficiency).