Add a check to Simulation which confirms that all Modules/Diagnostics have the data they need

[arichar6]

I've run into times when I changed my Simulation by removing a Module, and then the code crashes on the first call to fundamental_cycle because a Diagnostic couldn't find the data it was trying to output to file.

This type of crash could be easier to debug by inserting a check before the main simulation loop starts. The checking function could raise a more helpful error if all the modules did not find the data they need.

Such a check would have to go through each module/diagnostic and confirm (somehow) that all of the resources that it needs were actually found. This might require a modification to the way that resource sharing works.

Perhaps at the very least something like a resource_found flag could be set in the inspect_resource function.

[ndisner]

Is this issue already done? I feel like this is already being preformed because at runtime we have outputs that say "PhysicsModule is sharing ..." That is the check or should it be more detailed?

[arichar6]

So, yes and no. I added those outputs and they help some. But it might be nice to still have some sort of automated check like described in this issue.

[ndisner]

Okay I will work on this then!