Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODS run_bootstrap can return None #367

Closed
mdeceglie opened this issue May 5, 2023 · 2 comments
Closed

CODS run_bootstrap can return None #367

mdeceglie opened this issue May 5, 2023 · 2 comments

Comments

@mdeceglie
Copy link
Collaborator

When run_bootstrap detects a small soiling signal, it currently returns None (

rdtools/rdtools/soiling.py

Line 1769 in adf9f44

return
)

Suggested change is return self.result_df, self.degradation, self.soiling_loss
@martin-springer
Copy link
Collaborator

@mdeceglie - I created a pull request to address this issue #400

@martin-springer martin-springer mentioned this issue Oct 23, 2024
Closed
@mdeceglie
Copy link
Collaborator Author

Closed in #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdeceglie @martin-springer