Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/merge ac changes #3

Merged
merged 17 commits into from
Nov 26, 2024
Merged

Jd/merge ac changes #3

merged 17 commits into from
Nov 26, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Nov 26, 2024

Thanks for opening a PR to SIENNA-PACKAGE.jl, please take note of the following when making a PR:

Check the contributor guidelines

@jd-lara jd-lara merged commit 55a0873 into main Nov 26, 2024
3 of 7 checks passed
Comment on lines +1 to +6
# Internal API
```@autodocs
Modules = [SiennaTemplate]
Public = false
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
# Internal API
```@autodocs
Modules = [SiennaTemplate]
Public = false
```
# Internal API
```@autodocs
Modules = [SiennaTemplate]
Public = false
```

Comment on lines +1 to +6
# Public API Reference
```@autodocs
Modules = [SiennaTemplate]
Public = true
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
# Public API Reference
```@autodocs
Modules = [SiennaTemplate]
Public = true
```
# Public API Reference
```@autodocs
Modules = [SiennaTemplate]
Public = true
```

@jd-lara jd-lara deleted the jd/merge_ac_changes branch January 16, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants