Skip to content

Commit

Permalink
[chore] #13 코드 정리
Browse files Browse the repository at this point in the history
  • Loading branch information
Hyobeen-Park committed May 30, 2024
1 parent a3a3f81 commit 3d9b2f8
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 13 deletions.
17 changes: 10 additions & 7 deletions app/src/main/java/com/sopt/now/presentation/Home/HomeFragment.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.sopt.now.presentation.Home

import android.os.Bundle
import android.util.Log
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
Expand All @@ -11,11 +10,9 @@ import androidx.fragment.app.viewModels
import androidx.lifecycle.flowWithLifecycle
import androidx.lifecycle.lifecycleScope
import androidx.recyclerview.widget.ConcatAdapter
import com.sopt.now.domain.model.Friend
import com.sopt.now.databinding.FragmentHomeBinding
import com.sopt.now.presentation.Home.Friend.FriendAdapter
import com.sopt.now.presentation.Home.User.UserAdapter
import com.sopt.now.data.ServicePool
import com.sopt.now.databinding.FragmentHomeBinding
import com.sopt.now.presentation.Key.USERID
import com.sopt.now.presentation.common.ViewModelFactory
import com.sopt.now.util.UiState
Expand Down Expand Up @@ -65,25 +62,31 @@ class HomeFragment : Fragment() {

private fun collectUserInfo() {
homeViewModel.homeUserState.flowWithLifecycle(lifecycle).onEach { homeUserState ->
when(homeUserState) {
when (homeUserState) {
is UiState.Success -> {
userAdapter.setUserList(homeUserState.data)
}
is UiState.Error -> showToastMessage(homeUserState.message)

is UiState.Error -> {
showToastMessage(homeUserState.message)
}

else -> Unit
}
}.launchIn(lifecycleScope)
}

private fun collectFriendsList() {
homeViewModel.homeFriendState.flowWithLifecycle(lifecycle).onEach { homeFriendState ->
when(homeFriendState) {
when (homeFriendState) {
is UiState.Success -> {
friendAdapter.setFriendList(homeFriendState.data)
}

is UiState.Error -> {
showToastMessage(homeFriendState.message)
}

else -> Unit
}
}.launchIn(lifecycleScope)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
package com.sopt.now.presentation.Home

import android.util.Log
import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.sopt.now.domain.model.Friend
import com.sopt.now.domain.model.FriendsList
import com.sopt.now.domain.model.User
import com.sopt.now.domain.repository.AuthRepository
Expand All @@ -16,7 +14,7 @@ import kotlinx.coroutines.launch
class HomeViewModel(
private val authRepository: AuthRepository,
private val friendRepository: FriendRepository,
): ViewModel() {
) : ViewModel() {
private val _homeUserState = MutableStateFlow<UiState<User>>(UiState.Empty)
val homeUserState get() = _homeUserState.asStateFlow()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package com.sopt.now.presentation.Login

import android.content.Intent
import android.os.Bundle
import android.util.Log
import android.widget.Toast
import androidx.activity.viewModels
import androidx.appcompat.app.AppCompatActivity
Expand Down Expand Up @@ -57,7 +56,10 @@ class LoginActivity : AppCompatActivity() {
}
}

is UiState.Error -> showToastMessage(loginState.message)
is UiState.Error -> {
showToastMessage(loginState.message)
}

else -> Unit
}
}.launchIn(lifecycleScope)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ class SignupActivity : AppCompatActivity() {
startActivity(Intent(this@SignupActivity, LoginActivity::class.java))
}

is UiState.Error -> showToastMessage(R.string.server_connection_error)
is UiState.Error -> {
showToastMessage(R.string.server_connection_error)
}

else -> Unit
}
}.launchIn(lifecycleScope)
Expand Down

0 comments on commit 3d9b2f8

Please sign in to comment.