Convert GFS DDTs from blocked data structures to contiguous arrays: Part Deux #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/contiguous_arrays
…ture/contiguous_arrays
…ture/contiguous_arrays
…ture/contiguous_arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces using blocked data structures with contiguous data structures for external data types (GFS_diagnostics and GFS_restart). This work is a continuation of #798 and is described in UWM #2294.
Also, GFS_restart_type was refactored to be consistent with GFS_diagnostics_type. This simplifies the code and opens the possibility to unify some of the fv3 io modules.
Issue(s) addressed
UWM #2521
Testing
All UWM RTs pass on Hera and WCOSS.