Refactor GFDLMP v1. Introduce GFDLMP v3. Fix initialization bug. #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce28fae.
|
@dustinswales I'd like to test this version. How do I check this code? Thanks! |
|
git clone --recursive --branch feature/gfdlmpv3 https://github.com/dustinswales/ufs-weather-model.git |
|
Dependency: ufs-community/ccpp-physics#195 |
This reverts commit a609ad7.
14 tasks
|
@dustinswales Please pull in the latest develop. I pulled in the latest ufs/dev to ufs-community/ccpp-physics#195, thinking that maybe I had permission on your fv3atm and ufs-weather-model branches, but I didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*updated on 11/18/2024)
This PR contains host side changes to accommodate a new cloud microphysics parameterization in the physics.
For the refactoring, all of the configuration/namelist info is moved into a common module that is referenced by both MP versions and a shared fv_sat_adj.F90. There are default values for the scheme configurations defined within this module, and overwritten by the namelist, if provided. Both the v1 and v3 rely on some of the same parameters, but with different default values. This is handled by introducing a pre-processor directive into the new configuration module.
Note. The "initialization bug" results in itsy-bitsy changes to the results, and is not addressed in these changes. A complete solution would require the GFDL MP scheme namelist to be read in during the dycore initialization.
Testing
Tested on Hera using Intel
No changes to GFDL MP v1 enabled baselines (control_iovr4 and hafs_regional_atm)