Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug found in setting dimension for empty data category #54

Open
emilyhcliu opened this issue Feb 22, 2025 · 0 comments
Open

Bug found in setting dimension for empty data category #54

emilyhcliu opened this issue Feb 22, 2025 · 0 comments
Assignees

Comments

@emilyhcliu
Copy link
Collaborator

emilyhcliu commented Feb 22, 2025

Test case ATMS bufr (two dimensions data: Location, Channel)

  • contains 3 categories: npp, n20 and n21
  • ATMS bufr does not contain n21, so the output netCDF contains zero location and 22 channels.

Running bufr2netcdf test for ATMS with two versions of bufr-query using the same atms mapping file:

  • develop (after the encoder enhancement PR merged)
  • commit 8bc2886 (before the encoder enhancement PR merged)

The channel dimension is not set correctly (dim_2=22) in the output NetCDF from develop (check the first block below)

The channel dimension is set correctly (dimension=22) in the output NetCDF from commit 8bc2886 (check the second block below)

The output NetCDF hearer for atms_n21 from develop version:

netcdf gdas.t00z.atms_n21.tm00 {
dimensions:
        Location = UNLIMITED ; // (0 currently)
        dim_2 = 22 ;
variables:
        int Location(Location) ;
                Location:_FillValue = 2147483647 ;
        int dim_2(dim_2) ;
                dim_2:_FillValue = 2147483647 ;

// global attributes:
                :platformCommonName = "JPSS" ;
                :platformLongDescription = "Joint Polar Satellite System" ;
                :sensor = "Advanced Baseline Imager (ATMS)" ;
                :source = "NCEP BUFR Dump for ATMS brightness temperature data (atms normal feed)" ;
                :providerFullName = "National Environmental Satellite, Data, and Information Service" ;
                :processingLevel = "Level-1B" ;
                :converter = "BUFR" ;
data:

 dim_2 = 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ;

The output NETCDF header from atms_n21 from commit 8bc2886 :

netcdf gdas.t00z.atms_n21.tm00 {
dimensions:
        Channel = 22 ;
        Location = UNLIMITED ; // (0 currently)
variables:
        int Channel(Channel) ;
                Channel:_FillValue = 2147483647 ;
        int Location(Location) ;
                Location:_FillValue = 2147483647 ;

// global attributes:
                :platformCommonName = "JPSS" ;
                :platformLongDescription = "Joint Polar Satellite System" ;
                :sensor = "Advanced Baseline Imager (ATMS)" ;
                :source = "NCEP BUFR Dump for ATMS brightness temperature data (atms normal feed)" ;
                :providerFullName = "National Environmental Satellite, Data, and Information Service" ;
                :processingLevel = "Level-1B" ;
                :converter = "BUFR" ;
data:

 Channel = 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants