-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat 1-point datasets equally in sequential and parallel fits #2276
Conversation
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
This is ready for review. @achiefa please have a look if you have time to see whether this works for your use case. In principle it should store the replica pseudodata in each folder in GPU just like it does when you run sequentially. @comane to achieve this I've created a decorator which modifies reportengine's decorator. Not sure whether what I've done is legal or whether there's an easier more official way to achieve this? |
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
…d reportengine wrapper ; remove complicated validphys functio
fec4235
to
2b92347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with that. Some things were not clear to me. But I think that is because I don't have as strong a knowledge of the codebase as you have.
This is why it is important to have less experienced people doing the review, so they can become experienced! Thanks. I'll add the requested comments / docs. |
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Due to the shape-changing nature of boolean masks we decided to just put single-point datasets in training when running in GPU. This PR removes that limitation by just accepting the point in both training and validation and setting to 0 the row and column in the inverse covmat (so the masking happens at the level of the loss).
If this works ok, #2138 comes for free.
@RoyStegeman @achiefa I want to run a few tests first before considering this good:
.csv
files per replica(any help running the checks would be appreciated ofc, the more eyes the better)
This is needed for tree-saving reasons.