Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plottings for the collider LHCb datasets #2220

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Update plottings for the collider LHCb datasets #2220

merged 4 commits into from
Nov 22, 2024

Conversation

Radonirinaunimi
Copy link
Member

This PR modifies the following:

  • deprecate the use of kinematic_override
  • replace the process_type from EWK_RAP to DY_2L

The data vs theory comparisons and kinematic plots are identical:

old plotting new plotting
data vs theory comparison report report
kinematic plot report report

@scarlehoff scarlehoff mentioned this pull request Nov 21, 2024
Merged
@scarlehoff
Copy link
Member

is this now ready to go?

@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Nov 22, 2024 •
edited
Loading

is this now ready to go?

Yes (modulo rebase)! (For the sake of absolute comparisons, here is the data vs theory after the last commits)

scarlehoff
scarlehoff approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@scarlehoff scarlehoff merged commit 6edf250 into master Nov 22, 2024
6 checks passed
@scarlehoff scarlehoff deleted the update-collider-lhcb branch November 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarlehoff scarlehoff scarlehoff approved these changes

Assignees
No one assigned
Labels
data toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Radonirinaunimi @scarlehoff