-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement double differential distributions in ATLAS_TTBAR_13TEV_LJ_DIF #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t7phy
added a commit
that referenced
this pull request
Nov 22, 2024
or as JCM puts it, a prison sentence xD
t7phy
added a commit
that referenced
this pull request
Nov 24, 2024
or as JCM puts it, a prison sentence xD
t7phy
added a commit
that referenced
this pull request
Nov 26, 2024
or as JCM puts it, a prison sentence xD
t7phy
added a commit
that referenced
this pull request
Dec 4, 2024
or as JCM puts it, a prison sentence xD
scarlehoff
pushed a commit
that referenced
this pull request
Dec 6, 2024
or as JCM puts it, a prison sentence xD
scarlehoff
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just the two minor comments
nnpdf_data/nnpdf_data/commondata/ATLAS_TTBAR_13TEV_LJ_DIF/metadata.yaml
Outdated
Show resolved
Hide resolved
nnpdf_data/nnpdf_data/commondata/ATLAS_TTBAR_13TEV_LJ_DIF/metadata.yaml
Outdated
Show resolved
Hide resolved
or as JCM puts it, a prison sentence xD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
ATLAS_TTBAR_13TEV_LJ_DIF_MTTBAR-PTT
,ATLAS_TTBAR_13TEV_LJ_DIF_MTTBAR-PTT-NORM
,ATLAS_TTBAR_13TEV_LJ_DIF_PTT-YT
andATLAS_TTBAR_13TEV_LJ_DIF_PTT-YT-NORM
. The covariance matrices forPTT-YT
andPTT-YT_NORM
are bugged, however, they are left in the data implementation for completeness (and in case they are corrected by the experimentalists, re-downloading the hepdata files and rerunning the filter should be enough). The data-theory comparison is available here: https://vp.nnpdf.science/Eu-MC_FSR_-iGv7_gij3XA==The grids for these datasets will be added to nnpdf/theories_slim#43