Improve archive file sizes. #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR has now been updated to also pad all objects to a multiple of 256 bytes. This seriously helps with reuse of empty space at the price of every object being a bit larger. It turned out in the long run that this helped quite a bit with curbing file growth. |
Koenvh1
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the growth of (RRDP) archive files. It changes the strategy for updating objects that have grown in size to by trying to re-use empty space rather than just appending them.This PR improves the growth of RRDP archive files. It tries to re-use existing empty space when updating objects. It also pads all objects to a multiple of 256 bytes to make it more likely that empty space can be reused.
The PR also adds a new command
archive-statsthat prints statistics for an archive file.Finally, the PR raises the Minimum Supported Rust Version to 1.73 to be able to use
u64::next_multiple_of.