Fix bug with calculating quality evaluation #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves the quality evaluation on a few points:
- The stored value is no longer a calculated float. This helps us
avoid floating point precision problems in the database.
- The count is now correctly computed on full tree calculation.
- Previously this was not the case and could lead to miscalculated
averages after updates that happened after a full tree
calculation.
This makes calling `wipeQualityEvaluationAverages` slightly safer i think 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: Krever at vi kjører et kall til
/v1/admin/buildAverageTreefor å gjenskape snittene.Jeg tror denne skal fikse problemet med at kvalitetsvurderingssnittene noen ganger er feil.
Var en bug der som gjorde at databasen ikke var oppdatert ved en rekalkulering som gjorde at "count" var feil.
Dette vil jo propagere dersom noen oppdaterer et snitt som er feil.
Endrer også til at vi lagrer sum'en og heller regner ut snittet på vei ut av apiet. Dette gjør at vi unngår floating point precision problemer.