Add routine to disconnect all invisible children of subjects. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I test tok det litt under to minutter å kjøre publisering med dette. Merk at ingen noder faktisk slettes, men kun frakobles fra foreldrenoden. |
jnatten
reviewed
Dec 18, 2024
gunnarvelle
force-pushed
the
delete-invisibles
branch
from
bf78d78 to
bd8b7fa
Compare
Not 22
gunnarvelle
force-pushed
the
delete-invisibles
branch
from
bd8b7fa to
bfd8c21
Compare
jnatten
approved these changes
Jan 8, 2025
| deleter.setVersion(schemaFromHash(hash)); | ||
| executor.submit(deleter); | ||
| } catch (Exception e) { | ||
| logger.info(e.getMessage(), e); |
There was a problem hiding this comment.
Jeg husker vi snakka om det, men jeg husker ikke helt hva det var igjen. Hvorfor burde ikke denne være logger.error?
There was a problem hiding this comment.
Det kunne den fint vore, men tenkte berre at det ikkje gav så masse ekstra verdi. Vil sannsynligvis ikkje skje uansett.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lokalt går dette gjennom på noen minutter, men vil teste å lage en release som eg kjører på test.