From c02657705b00b7c4220c9139bc9663741ac09260 Mon Sep 17 00:00:00 2001 From: Gunnar Velle Date: Thu, 5 Dec 2024 18:13:43 +0100 Subject: [PATCH] Fix tests --- .../java/no/ndla/taxonomy/service/UrlResolverServiceImpl.java | 2 +- src/test/java/no/ndla/taxonomy/rest/v1/UrlResolverTest.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/no/ndla/taxonomy/service/UrlResolverServiceImpl.java b/src/main/java/no/ndla/taxonomy/service/UrlResolverServiceImpl.java index 9bc55c99..17152b1d 100644 --- a/src/main/java/no/ndla/taxonomy/service/UrlResolverServiceImpl.java +++ b/src/main/java/no/ndla/taxonomy/service/UrlResolverServiceImpl.java @@ -185,7 +185,7 @@ public Optional resolveUrl(String path, String language) { .orElse(ctx.path())); }); return Optional.of(resolvedUrl); - } catch (NotFoundServiceException e) { + } catch (Exception e) { return Optional.empty(); } } diff --git a/src/test/java/no/ndla/taxonomy/rest/v1/UrlResolverTest.java b/src/test/java/no/ndla/taxonomy/rest/v1/UrlResolverTest.java index 8db5a027..e76c4f4d 100644 --- a/src/test/java/no/ndla/taxonomy/rest/v1/UrlResolverTest.java +++ b/src/test/java/no/ndla/taxonomy/rest/v1/UrlResolverTest.java @@ -105,12 +105,12 @@ public void ignores_multiple_or_leading_or_trailing_slashes() throws Exception { } @Test - public void gets_404_on_wrong_path_to_resource() throws Exception { + public void gets_200_on_wrong_path_to_resource() throws Exception { builder.node(NodeType.SUBJECT, s -> s.isContext(true) .publicId("urn:subject:1") .child(NodeType.TOPIC, t -> t.publicId("urn:topic:1").resource(r -> r.publicId("urn:resource:1")))); - testUtils.getResource("/v1/url/resolve?path=/subject:1/topic:2/resource:1", status().isNotFound()); + testUtils.getResource("/v1/url/resolve?path=/subject:1/topic:2/resource:1", status().isOk()); testUtils.getResource("/v1/url/resolve?path=/subject:1/topic:1/resource:1", status().isOk()); }