-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Test upgrade - integration of Vulnerability Lookup #42
Conversation
…up for enrichment + visual upgrade Signed-off-by: Romain Kieffer <romain.kieffer@nc3.lu>
…atcher for Vulnerability Lookup connextion timeout Signed-off-by: Romain Kieffer <romain.kieffer@nc3.lu>
Signed-off-by: Romain Kieffer <romain.kieffer@nc3.lu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
files should not have spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to remove that from the tree. This is not used in the code, will remove on a later update. And I didn't name that file myself :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline css should be moved to a css file ideally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very specific to the report: this is used as the PDF template, and importing CSS does not work with the renderer (the {% static %} tag does not work, for example).
This template is not served on a web page, so I guess it's OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Added minor comments.
Generic requirements in order to contribute:
What does it do?
If it fixes an existing issue, please use GitHub syntax:
#<IssueID>
Questions
Release Type: