Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Test upgrade - integration of Vulnerability Lookup #42

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

romainkieffer
Copy link
Contributor

Generic requirements in order to contribute:

  • One Pull Request per fix/feature/change/...
  • Keep the amount of commits per PR as small as possible: if for any reason, you need to fix your commit after the pull request, please squash the changes in one single commit (or tell us why not)
  • Always make sure it is mergeable in the default branch
  • Any major changes adding a functionality should be disabled by default in the configuration

What does it do?

If it fixes an existing issue, please use GitHub syntax: #<IssueID>

Questions

  • Does it require a DB change?
  • Are you using it in production?

Release Type:

  • Major
  • Minor
  • Patch

…up for enrichment + visual upgrade

Signed-off-by: Romain Kieffer <romain.kieffer@nc3.lu>
…atcher for Vulnerability Lookup connextion timeout

Signed-off-by: Romain Kieffer <romain.kieffer@nc3.lu>
Signed-off-by: Romain Kieffer <romain.kieffer@nc3.lu>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files should not have spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove that from the tree. This is not used in the code, will remove on a later update. And I didn't name that file myself :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline css should be moved to a css file ideally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very specific to the report: this is used as the PDF template, and importing CSS does not work with the renderer (the {% static %} tag does not work, for example).
This template is not served on a web page, so I guess it's OK.

Copy link
Contributor

@pparage pparage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added minor comments.

@romainkieffer romainkieffer merged commit cfbc13d into main Nov 27, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants