Handle task scheduling in ResumableSimulationDriver

[adrienmaillard]

• Tickets addressed: Fixes State of resumable simulation driver is not properly maintained #1256
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Here is an example of how the issue has manifested:

• The scheduler has to simulate a plan with activities A and B with B anchored to A.
• After simulation, the scheduler tries to query the duration of task B, it fails
• Indeed, the resumable simulation driver does not have a direct reference to task B because of how anchored activities were managed, that is, by creating an anonymous task that would include the A, a delay, then B. The driver would remember the id of this anonymous task but not the id of task B precisely. The id of a task is given when the task is scheduled and in this case, the simulation engine would schedule task A and B, not the driver.

The solution consists in replacing this anonymous task creation with a mechanism that lets the driver schedule dependent tasks as soon as their dependent is finishing. Handling task creation allows to maintaining references to task ids and solve the above issue.

Verification

A simple test that was not passing before has been added.

Documentation

N/A

Future work

N/A

[Mythicaeda]

Could you either update or add a new Anchor Integration test in SchedulingIntegrationTests that uses a non-controllable duration activity? The fact that all of those tests use GrowBanana was how this bug slipped by for so long.

[adrienmaillard]

Good catch, I forgot this, I have updated the GrowBanana of one test to a PickBanana.

[adrienmaillard]

I'd like to point out that this PR is strictly removing code, which should be celebrated somehow :p

[Mythicaeda]

🎉