Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition plan spec being accessed incorrectly in ManagePlanSchedulingConditionsModal.svelte #1596

Closed
AaronPlave opened this issue Jan 17, 2025 · 1 comment · Fixed by #1604
Assignees
Labels
bug Something isn't working

Comments

@AaronPlave
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

develop

Describe the bug

The following line is assuming the store is a map when the store is actually an array so lookups will not behave correctly:

const conditionPlanSpec = $allowedSchedulingConditionSpecs[conditionId];

https://github.com/NASA-AMMOS/aerie-ui/blob/develop/src/components/modals/ManagePlanSchedulingConditionsModal.svelte#L224

Reproduction

See code

Logs

System Info

All

Severity

Moderate

@AaronPlave AaronPlave added the bug Something isn't working label Jan 17, 2025
@AaronPlave AaronPlave assigned AaronPlave and duranb and unassigned AaronPlave Jan 17, 2025
@duranb duranb added this to Aerie Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Todo in Aerie Jan 27, 2025
@dandelany
Copy link
Collaborator

Will be included with updates for #1478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants