Refactor - Phoenix Editor linting changes (#1629)

* moved `Queries` enum to dedicated enum file * removed `maxItems` from SearchableDropdown now that it is virtualized * remove unused arguments * reorganize packages
NASA-AMMOS · Feb 14, 2025 · f9e092e · f9e092e
1 parent 282301a
commit f9e092e
Show file tree

Hide file tree

Showing 26 changed files with 866 additions and 849 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -38,28 +38,40 @@
     "version": "node ./scripts/version.js"
   },
   "dependencies": {
+    "@codemirror/autocomplete": "^6.16.0",
+    "@codemirror/lang-json": "^6.0.1",
+    "@codemirror/language": "^6.10.1",
+    "@codemirror/lint": "^6.5.0",
     "@fontsource/jetbrains-mono": "^5.0.19",
+    "@lezer/generator": "^1.7.0",
+    "@lezer/highlight": "^1.2.0",
+    "@lezer/lr": "^1.4.0",
     "@nasa-jpl/aerie-ampcs": "^1.0.5",
     "@nasa-jpl/seq-json-schema": "^1.3.1",
     "@nasa-jpl/stellar": "^1.1.18",
+    "@neodrag/svelte": "^2.0.6",
     "@streamparser/json": "^0.0.17",
     "@sveltejs/adapter-node": "5.0.1",
     "@sveltejs/kit": "^2.5.4",
+    "@tanstack/svelte-virtual": "^3.11.2",
     "ag-grid-community": "32.2.0",
     "ajv": "^8.12.0",
     "bootstrap": "^5.3.0",
     "bootstrap-icons": "^1.11.0",
+    "codemirror": "^6.0.1",
     "cookie": "^0.6.0",
     "d3-array": "^3.2.4",
     "d3-axis": "^3.0.0",
     "d3-brush": "^3.0.0",
     "d3-drag": "^3.0.0",
+    "d3-format": "^3.1.0",
     "d3-quadtree": "^3.0.1",
     "d3-scale": "^4.0.2",
     "d3-scale-chromatic": "^3.0.0",
     "d3-selection": "^3.0.0",
     "d3-shape": "^3.2.0",
     "d3-time": "^3.1.0",
+    "d3-zoom": "^3.0.0",
     "fastest-levenshtein": "^1.0.16",
     "graphql-ws": "^5.16.2",
     "json-source-map": "^0.6.1",
@@ -78,18 +90,9 @@
     "toastify-js": "^1.12.0"
   },
   "devDependencies": {
-    "@codemirror/autocomplete": "^6.16.0",
-    "@codemirror/lang-json": "^6.0.1",
-    "@codemirror/language": "^6.10.1",
-    "@codemirror/lint": "^6.5.0",
-    "@lezer/generator": "^1.7.0",
-    "@lezer/highlight": "^1.2.0",
-    "@lezer/lr": "^1.4.0",
     "@playwright/test": "^1.49.1",
-    "@neodrag/svelte": "^2.0.6",
     "@poppanator/sveltekit-svg": "^4.2.1",
     "@sveltejs/vite-plugin-svelte": "^3.0.0",
-    "@tanstack/svelte-virtual": "^3.11.2",
     "@testing-library/svelte": "^4.0.2",
     "@types/cookie": "^0.6.0",
     "@types/d3-array": "^3.0.5",
@@ -114,9 +117,6 @@
     "@vitest/coverage-v8": "^1.4.0",
     "@vitest/ui": "^1.4.0",
     "cloc": "2.0.0-cloc",
-    "codemirror": "^6.0.1",
-    "d3-format": "^3.1.0",
-    "d3-zoom": "^3.0.0",
     "esbuild": "^0.24.0",
     "eslint": "^8.43.0",
     "eslint-config-prettier": "^9.1.0",

diff --git a/src/components/parcels/ParcelForm.svelte b/src/components/parcels/ParcelForm.svelte
@@ -150,7 +150,7 @@
     });
 
     if (parcelToParameterDictionariesToAdd.length > 0) {
-      await effects.createParcelToParameterDictionaries(parcelOwner, parcelToParameterDictionariesToAdd, user);
+      await effects.createParcelToParameterDictionaries(parcelToParameterDictionariesToAdd, user);
     }
 
     if (parcelToParameterDictionaryIdsToDelete.length > 0) {

diff --git a/src/components/scheduling/goals/SchedulingGoal.svelte b/src/components/scheduling/goals/SchedulingGoal.svelte
@@ -81,10 +81,10 @@
   }
 
   function onEnable(event: Event) {
-    const { value: enabled } = getTarget(event);
+    const { value: enabledUpdate } = getTarget(event);
     dispatch('updateGoalPlanSpec', {
       ...goalPlanSpec,
-      enabled: enabled as boolean,
+      enabled: enabledUpdate as boolean,
     });
   }
 
@@ -110,10 +110,10 @@
     });
   }
 
-  function simulateAfter(simulateAfter: boolean) {
+  function simulateAfter(simulateAfterUpdate: boolean) {
     dispatch('updateGoalPlanSpec', {
       ...goalPlanSpec,
-      simulate_after: simulateAfter,
+      simulate_after: simulateAfterUpdate,
     });
   }
 
@@ -129,10 +129,10 @@
     });
   }
 
-  function updatePriority(priority: number) {
+  function updatePriority(priorityUpdate: number) {
     dispatch('updateGoalPlanSpec', {
       ...goalPlanSpec,
-      priority,
+      priority: priorityUpdate,
     });
   }
 

diff --git a/src/components/sequencing/CommandPanel/SelectedCommand.svelte b/src/components/sequencing/CommandPanel/SelectedCommand.svelte
@@ -127,8 +127,14 @@
             {commandInfoMapper}
             {variablesInScope}
             setInEditor={debounce((token, val) => setInEditor(editorSequenceView, token, val), 250)}
-            addDefaultArgs={(commandNode, missingArgDefArray) =>
-              addDefaultArgs(commandDictionary, editorSequenceView, commandNode, missingArgDefArray, commandInfoMapper)}
+            addDefaultArgs={(commandNodeToAddArgs, missingArgDefs) =>
+              addDefaultArgs(
+                commandDictionary,
+                editorSequenceView,
+                commandNodeToAddArgs,
+                missingArgDefs,
+                commandInfoMapper,
+              )}
           />
         {/each}
 

diff --git a/src/components/sequencing/form/EnumEditor.svelte b/src/components/sequencing/form/EnumEditor.svelte
@@ -6,7 +6,6 @@
   import SearchableDropdown from '../../ui/SearchableDropdown.svelte';
 
   const SEARCH_THRESHOLD = 100;
-  const MAX_SEARCH_ITEMS = 1_000;
 
   export let argDef: FswCommandArgumentEnum;
   export let commandDictionary: CommandDictionary | null = null;
@@ -39,7 +38,6 @@
   {#if enumValues.length > SEARCH_THRESHOLD}
     <SearchableDropdown
       {options}
-      maxItems={MAX_SEARCH_ITEMS}
       on:change={onSelectReferenceModel}
       {selectedOptionValues}
       placeholder={value}