Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Clan Kill Logs #1454

Open
StudentAlleg opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1495
Open

Refactor Clan Kill Logs #1454

StudentAlleg opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1495

Comments

@StudentAlleg
Copy link
Collaborator

Improve fetching, load only by page, store player name

Possibly remove non-clan kills being tracked
@StudentAlleg StudentAlleg moved this from Intake to In progress in Mineplex Clans Feb 5, 2025
StudentAlleg added a commit to StudentAlleg/BetterPvP that referenced this issue Feb 5, 2025
@StudentAlleg
Mykindos#1454 - Refactor Clan Kill logs.
26276af 
Store player name in kill logs to avoid joins or fetching client. Don't re-fetch logs everytime a filter is updated. On load and reload switch to a temporary menu that loads by page, unfilterable.
Add PagedCollectionMenu, a PagedGui that fetches the new page contents when changed to that page.
Use locks to prevent concurrent modification of certain lists.
@StudentAlleg StudentAlleg linked a pull request Feb 5, 2025 that will close this issue
Draft
2 tasks
StudentAlleg added a commit to StudentAlleg/BetterPvP that referenced this issue Feb 12, 2025
@StudentAlleg
Mykindos#1454 - Refactor Clan Kill logs.
aa8249a 
Store player name in kill logs to avoid joins or fetching client. Don't re-fetch logs everytime a filter is updated. On load and reload switch to a temporary menu that loads by page, unfilterable.
Add PagedCollectionMenu, a PagedGui that fetches the new page contents when changed to that page.
Use locks to prevent concurrent modification of certain lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Mineplex Clans
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Clan Kill logs. StudentAlleg/BetterPvP
1 participant
@StudentAlleg