Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Responsive Button behavior in shop.js #387

Merged

Conversation

HarleenKaurBhullar
Copy link
Contributor

Pull Request Template

Summary

This commit makes the buttons in shop.js responsive, ensuring they adapt appropriately to various screen sizes and devices for a better user experience.

Fixes #362

Type of Change

Please mark [X] for applicable items:

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Screenshots/Videos

Here are screenshots for two different devices.
issue2corrected

issue2corrected2

Checklist

Please mark [X] for completed items:

  • [X ] My code follows the project's style guidelines
  • [X ] I have performed a self-review of my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • [X ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 2:54pm

Copy link

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@HarleenKaurBhullar
Copy link
Contributor Author

Please assign points for the completion of this task and the successful merging of PR #110 in the SWOC system.

@Mujtabaa07 Mujtabaa07 added SWOC Social Winter Of Code INTERMEDIATE labels Jan 25, 2025
@Mujtabaa07 Mujtabaa07 merged commit 19bfe2c into Mujtabaa07:main Jan 25, 2025
4 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @HarleenKaurBhullar for your contribution!

What's Next?

Keep up the fantastic work! 🚀

@HarleenKaurBhullar
Copy link
Contributor Author

Thank you! I’m excited to contribute more. Could you let me know when you’ll be updating the OS leaderboard points?

@HarleenKaurBhullar
Copy link
Contributor Author

@Mujtabaa07 please assign me points for this pr #387 and pr #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTERMEDIATE SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Buttons on the shop page are not responsive
2 participants