Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Twitter and Github icons' native colors while hovering over them at footer #372

Conversation

abhayybhatt
Copy link
Contributor

Fixes: #371

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

As it was just a styling issue, no other changes were made that could potentially affect the working of our website.

Screenshots

Old screenshots (before adding the hover colors):

Screenshot 2025-01-20 214750
Screenshot 2025-01-20 221040

New screenshots (after adding their native hover colors):

Screenshot 2025-01-20 222019
Screenshot 2025-01-20 222043

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

So, this PR fixes the issue described in #371 . Please merge this PR.
Thanks for your time!

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 3:51pm

Copy link

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@abhayybhatt
Copy link
Contributor Author

@Mujtabaa07 I've fixed the branch conflicts. Now it can be merged without any issues.

@Mujtabaa07 Mujtabaa07 added SWOC Social Winter Of Code BEGINNER labels Jan 25, 2025
@Mujtabaa07 Mujtabaa07 merged commit fa6640f into Mujtabaa07:main Jan 25, 2025
2 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @abhayybhatt for your contribution!

What's Next?

Keep up the fantastic work! 🚀

@abhayybhatt abhayybhatt deleted the fix/adding-hover-colour-to-twitter-and-github branch January 26, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No colour for Twitter and Github icons while hovering over them on footer
2 participants