Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added About to navbar #313

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Added About to navbar #313

merged 2 commits into from
Jan 13, 2025

Conversation

Itz-Sidra
Copy link
Contributor

Pull Request Template

Summary

Added the About link to the Navbar, which was previously available only in the footer. This improves navigation and user accessibility.

Fixes #300
N/A (This is a feature enhancement)

Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

  • Verified that the About link appears correctly in the Navbar.
  • Checked navigation to the About section/page works as expected.

Screenshots/Videos

image
image

Checklist

Please mark [X] for completed items:

  • [ X ] My code follows the project's style guidelines
  • [ X ] I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional Comment

Adding About has shifted the "Shop" on the right, which I will fix while doing issue #301

Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 11:00am

Copy link

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

Copy link
Contributor Author

@Itz-Sidra Itz-Sidra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BUG] Fix Dropdown Alignment and Styling in "Shop" Navigation Menu issue #301

Fixed the dropdown alignment of "Shop" also made sure that FAQ is also prperly visible on the Navbar

@Mujtabaa07 Mujtabaa07 added BEGINNER SWOC Social Winter Of Code labels Jan 13, 2025
@Mujtabaa07 Mujtabaa07 merged commit 4a02b5f into Mujtabaa07:main Jan 13, 2025
1 check passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @Itz-Sidra for your contribution!

What's Next?

Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add "About Us" to the Navigation Bar
2 participants