-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix for Premium Beans Responsive UI - Fixed the Cards moving out of frame #297
Merged
Mujtabaa07
merged 3 commits into
Mujtabaa07:main
from
CrystalFireSword:feature/premium-beans-responsivity-ui
Jan 13, 2025
Merged
Bug Fix for Premium Beans Responsive UI - Fixed the Cards moving out of frame #297
Mujtabaa07
merged 3 commits into
Mujtabaa07:main
from
CrystalFireSword:feature/premium-beans-responsivity-ui
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t all device sizes, the cards do not move out of the frame or get cut out
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! 🎉PR Checklist
Next Steps
Need help? Check our Contributing Guide Happy coding! 💻 |
|
CrystalFireSword
force-pushed
the
feature/premium-beans-responsivity-ui
branch
from
January 11, 2025 11:59
b11bc37
to
da19ee4
Compare
…ty-ui' into feature/premium-beans-responsivity-ui
… ensure that for almost all device sizes, the cards do not move out of the frame or get cut out.
Does this mean I have resolved the conflicts? I am new to this, so kindly help! Thanks in advance! @Mujtabaa07 |
🎉 Congratulations on Your Merged PR!Thank you @CrystalFireSword for your contribution! What's Next?
Keep up the fantastic work! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI of the Premium Beans change was fixed to ensure that for almost all device sizes, the cards do not move out of the frame or get cut out.
Pull Request Template
Summary
In the previous version, the UI of the Premium Beans page worked well for the full-screen view of a laptop, but under a mobile phone's screen size or under split screen, the cards for Arabica Bliss and Robusta Robusta Roast on the left and the Espresso Elite and Colombian Charm on the right moved out of the frame, and were only half-visible as the pictures attached to the issue. This issue was fixed by adjusting media parameters to cater to different screen sizes, and changed to a single column after a certain screen size so that cards do not move out of frame.
Fixes #293
Type of Change
Please mark [X] for applicable items:
Testing
Please describe the tests you performed to verify your changes:
(This is my first time making a pull request, please feel free point out to mistakes if there are any!)
Screenshots/Videos
Please attach relevant screenshots or videos demonstrating the changes.
1.1 PAGE BEFORE MAKING THE CHANGE (with cards overflowing to the sides)
PAGES AFTER MAKING CHANGES:
2. Page after further screen size reduction:
Page Under half-screen split screen size:
Page under average mobile phone screen size:
Checklist
Please mark [X] for completed items: