Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused and extra home menu and improve code #269

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dhruvdankhara
Copy link
Contributor

Summary

Remove extra unrendered menus like home which display two times which is not good. so remove this home and also refactor the navbar code.

Fixes #255

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Code refactoring

Testing

there is no need for any testing but I have checked in different screen sizes to see whether any problem occurred. It is fine and no error was found.

Screenshots

image

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 2:30pm

Copy link

github-actions bot commented Jan 9, 2025

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07 Mujtabaa07 added SWOC Social Winter Of Code BEGINNER labels Jan 9, 2025
@Mujtabaa07 Mujtabaa07 merged commit 0775fba into Mujtabaa07:main Jan 9, 2025
4 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @dhruvdankhara for your contribution!

What's Next?

Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Duplicate Home Menu Item in Navbar on Large Screens
2 participants