Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash message added on clicking add to cart button #244

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

Anurag-Kuche
Copy link
Contributor

@Anurag-Kuche Anurag-Kuche commented Jan 7, 2025

Pull Request Template

Summary

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Please describe the tests you performed to verify your changes:
I tested the flash message by adding products to the cart and confirming the success notification appeared and disappeared correctly. I also verified the toast message was clear and displayed as expected on different browsers and screen sizes

Screenshots/Videos

image

Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

close #226

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 2:41pm

Copy link

github-actions bot commented Jan 7, 2025

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07
Copy link
Owner

@Anurag-Kuche add your issue number

@Mujtabaa07
Copy link
Owner

Screenshot 2025-01-10 170530

@Anurag-Kuche I am unable to merge, resolve this conflict or re-raise the pr

@Anurag-Kuche
Copy link
Contributor Author

There is a merge conflict in the package-lock.json file that needs manual resolution. The resolve button is currently disabled, so please review and resolve the conflict in this file. Thank you!

@Mujtabaa07 Mujtabaa07 merged commit 76d0228 into Mujtabaa07:main Jan 10, 2025
2 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @Anurag-Kuche for your contribution!

What's Next?

Keep up the fantastic work! 🚀

@Mujtabaa07 Mujtabaa07 mentioned this pull request Jan 10, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTERMEDIATE SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash Messages on Adding to Cart
2 participants