Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the shop section #220

Closed
wants to merge 4 commits into from
Closed

Improved the shop section #220

wants to merge 4 commits into from

Conversation

abhas20
Copy link
Contributor

@abhas20 abhas20 commented Jan 5, 2025

Pull Request

Summary

The shop section under the website was having all the items listed under cofee , I have added four more sections and maped the items accordingly under each respective section.

Fixes #147

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

The code was successfully running on my device

Screenshots/Videos

Screenshot (101)
Screenshot (102)
Screenshot (103)
Screenshot (100)

Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ❌ Failed (Inspect) Jan 9, 2025 2:00pm

Copy link

github-actions bot commented Jan 5, 2025

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07
Copy link
Owner

@abhas20 resolve conflicts

@Mujtabaa07
Copy link
Owner

@abhas20
Screenshot 2025-01-09 193527
Fix this issue

@Mujtabaa07
Copy link
Owner

Screenshot 2025-01-21 213516

@abhas20 Fix it , it freezed merge button

@abhas20
Copy link
Contributor Author

abhas20 commented Jan 21, 2025

@Mujtabaa07 I had already created a new pr to remove this issue which was merged and this issue was closed.
So if this problem persists please confirm me so that I can fix it?

@abhas20 abhas20 closed this Jan 22, 2025
@abhas20 abhas20 deleted the improve branch January 22, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTERMEDIATE SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GENERAL] Adding different section uder shop
2 participants