Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a 'Register' button to the navbar and drop-down menu that directly navigates to the sign-up page. #152

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

aadi-joshi
Copy link
Contributor

@aadi-joshi aadi-joshi commented Jan 2, 2025

Summary

The issue stated that there is no 'Sign Up' button in the navbar that directly redirects to the register page. The proposed solution was to add a 'Register' button to the navbar that directly navigates to the sign-up page, rather than first navigating to the login page and then to the sign-up page, for better performance.
Hence I added a "Register" button to the navbar, and also to the dropdown menu. I also updated the README.md with the new screenshots, as well as added a comment where i made the changes.
Also, I have come here from Social Winter of Code.

Fixes #146

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

The project when run now, shows the newly added register button in the navbar.
We can see that it correctly navigates directly to the sign-up page, hence resolving the issue raised.

demo

It also works correctly in the drop down menu.

demo

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

…e sign-up page, added comments and updated README.md with new screenshots
…tly navigates to the sign-up page, added comments and updated README.md with new screenshots
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 7:29pm

Copy link

github-actions bot commented Jan 2, 2025

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07 Mujtabaa07 added SWOC Social Winter Of Code INTERMEDIATE labels Jan 2, 2025
@Mujtabaa07 Mujtabaa07 merged commit 4119652 into Mujtabaa07:main Jan 2, 2025
4 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @aadi-joshi for your contribution!

What's Next?

Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTERMEDIATE SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add "Register" button to the navbar.
2 participants