Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navbar and Checkout Heading Overlap Issue #143

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

sitambhra
Copy link
Contributor

Pull Request Template

Summary

This pull request addresses the issue where the checkout heading was overlapping with the navbar. The following changes were made:

  • Adjusted the layout and spacing between the navbar and the checkout heading to ensure proper alignment and visibility.
  • Verified responsiveness on various screen sizes to ensure consistent behavior across devices.
  • Tested functionality to confirm no other UI elements were affected by this fix.

Fixes #123 (issue)

Note:
Apart from addressing the problems in #107 , I also ensured button responsiveness on small screens—a separate issue I could have raised but chose to solve within #107 . Considering the extensive changes made throughout in #107 , could you kindly update the label from "Intermediate" to "Advanced"? Thank you!

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Code refactoring

Testing

Tested changes thoroughly on various screen sizes, including small screens, to ensure proper responsiveness

Screenshots/Videos

Before:
image
After:
You can see changes once #107 issue is merged. as there is no gateway right now that directs to checkout page. Once #107 is merged you can see a separate "Buy now button" which will redirect to Checkout page.

Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 3:25pm

Copy link

github-actions bot commented Jan 2, 2025

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07 Mujtabaa07 added bug Something isn't working SWOC Social Winter Of Code BEGINNER labels Jan 2, 2025
@Mujtabaa07 Mujtabaa07 merged commit 4192a89 into Mujtabaa07:main Jan 2, 2025
4 checks passed
@Mujtabaa07
Copy link
Owner

🎉 Congratulations on Your Merged PR!

Thank you @Sitambhra02 for your contribution!

What's Next?

Keep up the fantastic work! 🚀

@sitambhra
Copy link
Contributor Author

@Mujtabaa07 can you please assign me points on Oslead for the Merged Prs!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER bug Something isn't working SWOC Social Winter Of Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <write a small description here> Improving the visibility of Checkout Page.
2 participants