Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dirac thresholds and config files #22

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

giro94
Copy link
Contributor

@giro94 giro94 commented Feb 12, 2025

Dirac thresholds are now properly read from configuration files that are opened via environment variable.
Also, new thresholds for boards 80-159

@giro94
Copy link
Contributor Author

giro94 commented Feb 12, 2025

Ready to merge

@giro94
Copy link
Contributor Author

giro94 commented Feb 12, 2025

Wait before merging -- I will remove the baseline files later today

@giro94 giro94 marked this pull request as draft February 12, 2025 20:07
@giro94
Copy link
Contributor Author

giro94 commented Feb 12, 2025

Ok, now ready for merge

@giro94 giro94 marked this pull request as ready for review February 12, 2025 23:00
Copy link
Contributor

@rrivera747 rrivera747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@giro94 giro94 merged commit 3e2a24f into develop Feb 12, 2025
4 of 7 checks passed
@giro94 giro94 deleted the pgirotti/FixedThresholds branch February 12, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants