Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google+ APIs being shutdown on March 7, 2019 #586

Closed
Elointz opened this issue Jan 2, 2019 · 9 comments
Closed

Google+ APIs being shutdown on March 7, 2019 #586

Elointz opened this issue Jan 2, 2019 · 9 comments

Comments

@Elointz
Copy link

Elointz commented Jan 2, 2019

Any plans to update for support of Google Sign-In? (https://developers.google.com/identity/)
The current implementation is for Google+ Sign-In which will be deprecated.
https://developers.google.com/identity/sign-in/web/quick-migration-guide

@thomasmichaelwallace
Copy link

thomasmichaelwallace commented Jan 2, 2019

For information: PR #451 looks like it deals with this.

Scrap that- it just updates them, it still keeps all the google plus api endpoints.

@ptrwtts
Copy link

ptrwtts commented Jan 22, 2019

Any update on this? Or has anyone figured out a way to update the library to support the new system?

@thomasmichaelwallace
Copy link

It's not much, but we used the following workaround to maintain access to simple logging-in with 'me' functionality:

// provides a hello module for the tiny subset of the Google API used by DevicePilot.
// required while hello.js does not have a fix for the retirement of google plus.
// https://github.com/MrSwitch/hello.js/issues/586

const google = {
  name: 'Google Identity',
  oauth: {
    version: 2,
    auth: 'https://accounts.google.com/o/oauth2/v2/auth',
    response_type: 'token',
  },
  scope: {
    email: 'https://www.googleapis.com/auth/userinfo.email',
    profile: 'https://www.googleapis.com/auth/userinfo.profile',
  },
  scope_delim: ' ',
  base: 'https://www.googleapis.com/',
  get: { me: 'userinfo/v2/me' },
  form: false,
};

module.exports = function apply(hello) {
  hello.init({ google });
};

Provide your hello instance to this function and it'll override the google implementation to use the non-G+ endpoints.

@MrSwitch
Copy link
Owner

Hi all

If you can test the proposed PR #451 and endorse it i will merge it in.

Thanks

@thomasmichaelwallace
Copy link

thomasmichaelwallace commented Jan 25, 2019

Hi @MrSwitch - unfortunately that PR does not address this issue as it still uses the G+ api

For example:

me: 'plus/v1/people/me',

Unfortunately I haven't found time to find api replacements for the comprehensive job the built-in google support has (which is why I fell back on my much cut-back workaround). It might be possible that some functionality doesn't have a migration path (things like friends and feed).

@Elointz
Copy link
Author

Elointz commented Feb 28, 2019

One week left. Any update on this or suggestion on alternative libraries that will work?
Edit: checked the commit history. I will try the v1.18 release by @MrSwitch and get back.

Update: Compared to #451 v1.18.1 seems to work better. Guess I can only wait now and check my logs in Google Console if plus.people.get requests disappears.

@MrSwitch
Copy link
Owner

#590 was merged into v1.18.1 thanks.

I haven't tested this extensively so please do, i'll leave this open for now

@thomasmichaelwallace
Copy link

Just a note to say that v1.18.1 is working fine for us. 💯

@Elointz
Copy link
Author

Elointz commented Mar 4, 2019

Working fine for me too. No more calls seen in Google Console.

@Elointz Elointz closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants