Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-19779] Delete user modification endpoints #90

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

IlyasDevelopment
Copy link
Contributor

Change Summary

Since integration with an external authentication system (SSO, LDAP) is planned, where the name cannot be changed simply like that and the user activity is checked at the moment of authentication by means of the external system itself, the following routes are deleted:
PATCH /v1/user/:id
POST /v1/user/activate
POST /v1/user/deactivate

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment added the ci:skip-changelog Add this label to skip changelog file check label Sep 27, 2024
@IlyasDevelopment IlyasDevelopment self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (b9e138f) to head (09b073f).
Report is 91 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #90      +/-   ##
===========================================
- Coverage    92.95%   92.77%   -0.19%     
===========================================
  Files           84       84              
  Lines         2456     2435      -21     
  Branches       308      301       -7     
===========================================
- Hits          2283     2259      -24     
- Misses         121      125       +4     
+ Partials        52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment merged commit 8f23f1b into develop Sep 27, 2024
18 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-19779 branch September 27, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants