Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-19838] Update Makefile & CONTRIBUTING.rst #85

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 19, 2024

Change Summary

  • Sync Makefile with Data.Rentgen & Horizon implementations
  • Rewrite CONTRIBUTING.rst according to changes above
  • Running tests from local interpreter + using worker running inside docker container leads to issue. Conftest using address postgres://localhost:5433 to prepare source/target, and to create connections in database. But worker should access postgres://test-postges:5432, because it is running in the docker container within the same network. I've splitted up host+port for conftest & worker into different env variables, to solve this issue.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Sep 19, 2024
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (59795ae) to head (816051d).
Report is 96 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
+ Coverage    92.86%   92.88%   +0.02%     
===========================================
  Files           84       84              
  Lines         2452     2461       +9     
  Branches       309      309              
===========================================
+ Hits          2277     2286       +9     
  Misses         122      122              
  Partials        53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 2f0ba59 into develop Sep 20, 2024
17 checks passed
@dolfinus dolfinus deleted the feature/DOP-19838 branch September 20, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants