Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22145] Add file_name_template field #196

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Feb 4, 2025

Change Summary

  • Added the file_name_template field to target_params for file connectors. Default value set to:

    {run_created_at}_{index}.{extension}
    
  • Implemented a basic validator using str.format():

    • index and extension are mandatory placeholders
    • run_created_at and run_id are optional placeholders.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Feb 4, 2025
@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review February 5, 2025 07:10
@IlyasDevelopment IlyasDevelopment merged commit 40a0857 into develop Feb 5, 2025
23 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-22145 branch February 5, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants