Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22336] Add logic for handling WebDAV transfers #194

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Feb 3, 2025

Change Summary

  • Added necessary DTOs for WebDAV integration
  • Implemented WebDAV handler:
    • For reading, used a combination of FileDownloader and FileDFReader
    • For writing, used FileDFWriter and FileUploader
  • Added a container with WebDAV server for testing purposes
  • Developed integration tests for reading and writing files via WebDAV
  • Updated CI pipeline to include the execution of integration tests

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Feb 3, 2025
@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review February 3, 2025 10:45
@IlyasDevelopment IlyasDevelopment merged commit 49273f2 into develop Feb 3, 2025
24 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-22336 branch February 3, 2025 10:48
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (53bfdaf) to head (d0ee1bb).
Report is 68 commits behind head on develop.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (92.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #194       +/-   ##
==========================================
- Coverage    90.42%      0   -90.43%     
==========================================
  Files          157      0      -157     
  Lines         3560      0     -3560     
  Branches       261      0      -261     
==========================================
- Hits          3219      0     -3219     
+ Misses         277      0      -277     
+ Partials        64      0       -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants